kernelapp: Allow preserving stdout and stderr in kernel #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Carreau |
minrk
reviewed
Apr 2, 2018
ipykernel/kernelapp.py
Outdated
| sys.stdout = outstream_factory(self.session, self.iopub_thread, u'stdout') | ||
| sys.stdout = outstream_factory(self.session, self.iopub_thread, | ||
| u'stdout', | ||
| echo=sys.__stdout__) |
There was a problem hiding this comment.
This shouldn't be the default behavior. The default stdout/stderr should only be redirected by default.
There was a problem hiding this comment.
@minrk I figured as much. How do you think this would be best configured. A property on the kernel class or a property on the kernel app?
There was a problem hiding this comment.
Updated to be controlled by a quiet attribute. Similar to no_stdout.
ipykernel/iostream.py
Outdated
| try: | ||
| self.echo.write(string) | ||
| except OSError as e: | ||
| if self.echo != sys.__stderr__: |
cHYzZQo
force-pushed
the
echo-std-pipes
branch
8 times, most recently
from
6dcfe77
to
7f9e5a5
Compare
minrk
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to be able to have access to stdout/stderr the normal way so I threw together the following patch.
I imagine others might want a way to turn this off but I figured I'd share and we can refine further if others are interested.